-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coin-utils: add v2.11.11, apply autoreconf, use OpenBLAS, add GLPK support #23532
base: master
Are you sure you want to change the base?
Conversation
This should fix the cross-building and MSVC DLL building issues, hopefully.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
# should be packaged and added to build requirements. | ||
if hasattr(self, "settings_build") and cross_building(self) and self.options.shared: | ||
raise ConanInvalidConfiguration("coin-utils shared not supported yet when cross-building") | ||
self.requires("openblas/0.3.26") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.requires("openblas/0.3.26") | |
self.requires("openblas/0.3.27") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll handle this once the two prerequisite PRs have been merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a requirement bump
Hi @valgur, When building coin-clp (#23534) locally with coin-utils (this PR) previously built to be existing in my conan cache, I got following error:
This issue seems related to the addition of the openblas requirement. Regards. |
Also sets
--enable-coinutils-threads
on systems where it is supported.I did not make BLAS and LAPACK support optional as using COIN-OR libraries without them barely makes sense, really. Can be added later, if necessary.
GLPK is used in most of the COIN-OR packages, but is GPL-licensed, so I included an option to disable it.
Requires